B-20313: Prevent Role List Duplication

[TevinAdams]

B-20313

INT PR

Summary

In Admin App when viewing an Office Users Roles the roles list would sometimes duplicate. It is very inconsistent when this happens and may not even happen for us locally. I remember during PI planning that this was being cause because the GET Office-users call would return duplicate roles. Although i could not reproduce locally I was able to work with Alex to reproduce in loadtest to make sure that what was happening with the API endpoint during PI planning is exactly what is causing the duplication on the Admin UI now. (See screenshot below)

Notice the roles are duplicated in the payload. The AdminAPI displays what it receives from this call.

this article explains more about the approach used.

Verification Steps for the Author

These are to be checked by the author.

• Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
• Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

• Has the branch been pulled in and checked out?
• Have the BL acceptance criteria been met for this change?
• Was the CircleCI build successful?
• Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

• Instructions for starting storybook
• Instructions for starting the MilMove application
• Instructions for running tests

How to test

1. Access the Admin App
2. Login as an admin user
3. Go to view an Office user
4. Make sure roles are not duplicating in the user roles list
   

Frontend

• There are no aXe warnings for UI.
• This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
• There are no new console errors in the browser devtools.
• There are no new console errors in the test output.
• If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
• This change meets the standards for Section 508 compliance.

Backend

• Code follows the guidelines for Logging.
• The requirements listed in Querying the Database Safely have been satisfied.

Database

Any new migrations/schema changes:

• Follows our guidelines for Zero-Downtime Deploys.
• Have been communicated to #g-database.
• Secure migrations have been tested following the instructions in our docs.

Screenshots