Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the crate
rust-yaml
withserde_yaml
asrust-yaml
did not have any updates for 3 years since writing and also the maintainer seems to not be contact-able (chyh1990/yaml-rust#160).Though
serde_yaml
has also been archived (and deprecated) about 2 weeks ago (at time of writing), we now use a serde struct and could transition over to a different format (like json) easily, or wait until another serde yaml parser comes out (maybeserde_yml
will be trusted?).At least for now
serde_yaml
will continue to work.In additon this PR also cleans-up the
usize
casting forColorTermusic
.Also now all the themes in
/lib/themes/
will be tested to actually be load-able when runningcargo test
.PS: the struct
Alacritty
could be replaced with the newTheme
, though that would require a config transition, which is out-of-scope for this PR.