Refactor section definitions (extract sections) #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Envek
reviewed
Nov 26, 2017
| end | ||
| Hash[data] | ||
| def to_h(except: nil, only: nil, **) | ||
| obj = self.class.sections.values.map { |s| s.call(self) }.reduce({}, :merge) |
There was a problem hiding this comment.
I think it is somewhat not optimal to calculate all values and then throw out some or most of them.
There was a problem hiding this comment.
Ahh! Yes, you are right
It would be better to filter out sections, not calculated values
Envek
reviewed
Nov 26, 2017
| end | ||
| Hash[data] | ||
| def to_h(except: nil, only: nil, **) | ||
| obj = self.class.sections.values.map { |s| s.call(self) }.reduce({}, :merge) |
There was a problem hiding this comment.
Also, it is worth to use merge! to reduce the number of allocations.
Envek
reviewed
Nov 26, 2017
| def to_h(except: nil, only: nil, **) | ||
| obj = self.class.sections.values.map { |s| s.call(self) }.reduce({}, :merge) | ||
| obj = obj.reject { |k, _| Array(except).map(&:to_sym).include? k } if except | ||
| obj = obj.select { |k, _| Array(only).map(&:to_sym).include? k } if only |
There was a problem hiding this comment.
reject! and select! too may help to reduce memory footprint.
|
@Envek please add your fixes to your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gzigzigzeo Here I've just the proposed refactoring without adding any new features.
@Envek Now you can prepare you changes by reloading section definitions either implicitly, or explicitly (for example, you could add
option :reload, true.method(:&), optional: trueto the section and check it inTram::Page#section). Be aware of https://github.com/tram-rb/tram-page/pull/5/files#diff-f279a26eb24bc37345ac55d12c85bbb0R13I think, you guys should define an appropriate behavior that suites the both commercial projects.