Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don’t build empty objects on missing linked resources. #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/json-api-vanilla/parser.rb
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,9 @@ def self.build(hash)
obj = objects[[o_hash['type'], o_hash['id']]]
if o_hash['relationships']
o_hash['relationships'].each do |key, value|
# Instantiate ref initially
ref = nil

if value['data']
data = value['data']
if data.is_a?(Array)
Expand All @@ -96,7 +99,6 @@ def self.build(hash)
end
end

ref = ref || Object.new
set_key(obj, key, ref, original_keys)

rel_links[ref] = value['links']
Expand Down
2 changes: 1 addition & 1 deletion lib/json-api-vanilla/version.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
module JSON
module Api
module Vanilla
VERSION = '1.0.2'
VERSION = '1.0.3'
end
end
end