Skip to content

Conversation

@frabert
Copy link
Collaborator

@frabert frabert commented May 20, 2025

Fixes instafix#95

…vm#135772)

Add APIntParameter with custom implementation for comparison and use it
in llvm.constant_range attribute. This is necessary because the default
equality operator of APInt asserts when the bit widths of the compared
APInts differ. The comparison is used by StorageUniquer when hashes of
two ranges with different bit widths collide.
@frabert frabert requested a review from Jezurko May 20, 2025 14:44
@frabert frabert merged commit 6f03548 into main May 20, 2025
4 checks passed
@frabert frabert deleted the frabert/fix-95 branch May 21, 2025 10:10
frabert added a commit that referenced this pull request May 23, 2025
…vm#135772) (#36)

Add APIntParameter with custom implementation for comparison and use it
in llvm.constant_range attribute. This is necessary because the default
equality operator of APInt asserts when the bit widths of the compared
APInts differ. The comparison is used by StorageUniquer when hashes of
two ranges with different bit widths collide.

Co-authored-by: Robert Konicar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants