Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect and drop broken conns in the fastproxy pool #11212

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

kevinpollet
Copy link
Member

What does this PR do?

This pull request fixes the fastproxy pool to detect a broken connection and avoid returning it when a connection is acquired. It also avoids to send the body back to the client when the response status code does not allow it.

Motivation

To avoid bad gateway errors when a backend connection is broken.

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

Co-authored-by: Romain [email protected]

Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lbenguigui lbenguigui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit e3ed52b into traefik:v3.2 Oct 25, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants