Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Traefik Hub): AIServices are available in API Gateway #1333

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

juliens
Copy link
Member

@juliens juliens commented Feb 4, 2025

What does this PR do?

This PR moves the rbac for aiservices to Hub API GW instead of only Hub APIM

Motivation

Be able to use AIServices in Hub API GW

More

  • Yes, I updated the tests accordingly
  • Yes, I updated the schema accordingly
  • Yes, I ran make test and all the tests passed

Copy link
Contributor

@darkweaver87 darkweaver87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mloiseleur mloiseleur changed the title aiservices are available in Hub API GW fix(Traefik Hub): AISServices are available in Hub API GW Feb 6, 2025
@mloiseleur mloiseleur changed the title fix(Traefik Hub): AISServices are available in Hub API GW fix(Traefik Hub): AIServices are available in Hub API GW Feb 6, 2025
@mloiseleur mloiseleur changed the title fix(Traefik Hub): AIServices are available in Hub API GW fix(Traefik Hub): AIServices are available in API Gateway Feb 6, 2025
mloiseleur
mloiseleur previously approved these changes Feb 6, 2025
Copy link
Member

@mloiseleur mloiseleur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my suggestion.

@traefiker traefiker merged commit e18b8ad into traefik:master Feb 7, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants