-
Notifications
You must be signed in to change notification settings - Fork 1k
fix(dataset): add support for file cells in datasets with upload and external URL linking capabilities #3462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
5c18471
feat(dataset): add support for file cells in datasets with upload and…
galzilber cc20bc1
nl
galzilber 70ba304
fix(dataset): handle request exceptions during file upload to S3
galzilber f21926c
refactor(dataset): enhance dataset module by adding file cell types a…
galzilber a8ad5fd
fx
galzilber c284acf
rm
galzilber 469700c
refactor(tests): remove unused Mock import and clean up assertion for…
galzilber 01d0f22
format
galzilber cc0c5b6
fix
galzilber fd39dfe
fx
galzilber 443c64f
rm
galzilber 94659ab
fx
galzilber bfe3250
fx
galzilber 32e15b8
fx
galzilber 3543f6a
fx
galzilber 4ba485c
fx
galzilber cee7fb7
fx
galzilber 77b8c26
Refactor code for improved functionality and performance
galzilber 8b13f98
fx
galzilber 65c207d
fx
galzilber cd925a4
Merge branch 'main' into gz/add-files-to-dataset
galzilber bc8a5ca
fx
galzilber e08cf4b
fx
galzilber 5cee01d
fix(traceloop-sdk): enhance type annotations and improve data handlin…
galzilber 9b00146
fx
galzilber 2d5f510
Merge branch 'main' into gz/add-files-to-dataset
galzilber 75d7541
fx
galzilber 8157cfe
Merge branch 'gz/add-files-to-dataset' of github.com:traceloop/openll…
galzilber fb871d9
refactor(sdk): migrate dataset-related classes to a new 'datasets' mo…
galzilber 992c75c
Merge branch 'main' into gz/add-files-to-dataset
galzilber File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
238 changes: 238 additions & 0 deletions
238
...aceloop-sdk/tests/dataset/cassettes/test_file_operations/test_external_url_file_cell.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,238 @@ | ||
| interactions: | ||
| - request: | ||
| body: '{"slug": "test-external-url", "name": "Test External URL", "description": | ||
| null, "columns": [{"slug": "video", "name": "Video", "type": "file"}], "rows": | ||
| [{"video": null}]}' | ||
| headers: | ||
| Accept: | ||
| - '*/*' | ||
| Accept-Encoding: | ||
| - gzip, deflate | ||
| Connection: | ||
| - keep-alive | ||
| Content-Length: | ||
| - '171' | ||
| Content-Type: | ||
| - application/json | ||
| User-Agent: | ||
| - python-requests/2.32.3 | ||
| X-Traceloop-SDK-Version: | ||
| - 1.0.0 | ||
| method: POST | ||
| uri: https://api-staging.traceloop.com/v2/datasets | ||
| response: | ||
| body: | ||
| string: '{"id":"cmidcdrtw001e01r5dpaj14lb","slug":"test-external-url","name":"Test | ||
| External URL","columns":{"video":{"slug":"video","name":"Video","type":"file"}},"total_columns":1,"created_at":"2025-11-24T16:09:10.436228861Z","updated_at":"2025-11-24T16:09:10.436228917Z","rows":[{"id":"cmidcdru1001f01r5bp36hc4b","row_index":1,"values":{"video":null},"created_at":"2025-11-24T16:09:10.444214426Z","updated_at":"2025-11-24T16:09:10.444214426Z"}]}' | ||
| headers: | ||
| CF-RAY: | ||
| - 9a3a2b4fbb610bed-TLV | ||
| Connection: | ||
| - keep-alive | ||
| Content-Length: | ||
| - '438' | ||
| Content-Type: | ||
| - application/json; charset=utf-8 | ||
| Date: | ||
| - Mon, 24 Nov 2025 16:09:10 GMT | ||
| Permissions-Policy: | ||
| - geolocation=(self), microphone=() | ||
| Server: | ||
| - cloudflare | ||
| cf-cache-status: | ||
| - DYNAMIC | ||
| referrer-policy: | ||
| - strict-origin-when-cross-origin | ||
| strict-transport-security: | ||
| - max-age=7776000; includeSubDomains | ||
| via: | ||
| - kong/3.7.1 | ||
| x-content-type: | ||
| - nosniff | ||
| x-kong-proxy-latency: | ||
| - '0' | ||
| x-kong-request-id: | ||
| - e131c210c0b70c752cee1766f974b23c | ||
| x-kong-upstream-latency: | ||
| - '15' | ||
| status: | ||
| code: 201 | ||
| message: Created | ||
| - request: | ||
| body: '{"type": "video", "url": "https://www.youtube.com/watch?v=example", "metadata": | ||
| {}}' | ||
| headers: | ||
| Accept: | ||
| - '*/*' | ||
| Accept-Encoding: | ||
| - gzip, deflate | ||
| Connection: | ||
| - keep-alive | ||
| Content-Length: | ||
| - '83' | ||
| Content-Type: | ||
| - application/json | ||
| User-Agent: | ||
| - python-requests/2.32.3 | ||
| X-Traceloop-SDK-Version: | ||
| - 1.0.0 | ||
| method: POST | ||
| uri: https://api-staging.traceloop.com/v2/datasets/test-external-url/rows/cmidcdru1001f01r5bp36hc4b/cells/video/external-url | ||
| response: | ||
| body: | ||
| string: '{"storage":"external","success":true,"url":"https://www.youtube.com/watch?v=example"}' | ||
| headers: | ||
| CF-RAY: | ||
| - 9a3a2b50fd425591-TLV | ||
| Connection: | ||
| - keep-alive | ||
| Content-Encoding: | ||
| - gzip | ||
| Content-Type: | ||
| - application/json; charset=utf-8 | ||
| Date: | ||
| - Mon, 24 Nov 2025 16:09:10 GMT | ||
| Permissions-Policy: | ||
| - geolocation=(self), microphone=() | ||
| Server: | ||
| - cloudflare | ||
| Transfer-Encoding: | ||
| - chunked | ||
| cf-cache-status: | ||
| - DYNAMIC | ||
| referrer-policy: | ||
| - strict-origin-when-cross-origin | ||
| strict-transport-security: | ||
| - max-age=7776000; includeSubDomains | ||
| via: | ||
| - kong/3.7.1 | ||
| x-content-type: | ||
| - nosniff | ||
| x-kong-proxy-latency: | ||
| - '1' | ||
| x-kong-request-id: | ||
| - 4a52065fe7935b3d41c5da7c9f3ccd34 | ||
| x-kong-upstream-latency: | ||
| - '12' | ||
| status: | ||
| code: 200 | ||
| message: OK | ||
| - request: | ||
| body: '{"slug": "test-external-url", "name": "Test External URL", "description": | ||
| null, "columns": [{"slug": "video", "name": "Video", "type": "file"}], "rows": | ||
| [{"video": null}]}' | ||
| headers: | ||
| Accept: | ||
| - '*/*' | ||
| Accept-Encoding: | ||
| - gzip, deflate | ||
| Connection: | ||
| - keep-alive | ||
| Content-Length: | ||
| - '171' | ||
| Content-Type: | ||
| - application/json | ||
| User-Agent: | ||
| - python-requests/2.32.3 | ||
| X-Traceloop-SDK-Version: | ||
| - 1.0.0 | ||
| method: POST | ||
| uri: https://api-staging.traceloop.com/v2/datasets | ||
| response: | ||
| body: | ||
| string: '{"id":"cmidceiv1001g01r5oyxixw05","slug":"test-external-url","name":"Test | ||
| External URL","columns":{"video":{"slug":"video","name":"Video","type":"file"}},"total_columns":1,"created_at":"2025-11-24T16:09:45.469472315Z","updated_at":"2025-11-24T16:09:45.469472405Z","rows":[{"id":"cmidceiv6001h01r5odn89gid","row_index":1,"values":{"video":null},"created_at":"2025-11-24T16:09:45.477132645Z","updated_at":"2025-11-24T16:09:45.477132645Z"}]}' | ||
| headers: | ||
| CF-RAY: | ||
| - 9a3a2c2aa8b758a1-TLV | ||
| Connection: | ||
| - keep-alive | ||
| Content-Length: | ||
| - '438' | ||
| Content-Type: | ||
| - application/json; charset=utf-8 | ||
| Date: | ||
| - Mon, 24 Nov 2025 16:09:45 GMT | ||
| Permissions-Policy: | ||
| - geolocation=(self), microphone=() | ||
| Server: | ||
| - cloudflare | ||
| cf-cache-status: | ||
| - DYNAMIC | ||
| referrer-policy: | ||
| - strict-origin-when-cross-origin | ||
| strict-transport-security: | ||
| - max-age=7776000; includeSubDomains | ||
| via: | ||
| - kong/3.7.1 | ||
| x-content-type: | ||
| - nosniff | ||
| x-kong-proxy-latency: | ||
| - '1' | ||
| x-kong-request-id: | ||
| - 8b75804253bc6604d195677ca4ad196a | ||
| x-kong-upstream-latency: | ||
| - '13' | ||
| status: | ||
| code: 201 | ||
| message: Created | ||
| - request: | ||
| body: '{"type": "video", "url": "https://www.youtube.com/watch?v=example", "metadata": | ||
| {}}' | ||
| headers: | ||
| Accept: | ||
| - '*/*' | ||
| Accept-Encoding: | ||
| - gzip, deflate | ||
| Connection: | ||
| - keep-alive | ||
| Content-Length: | ||
| - '83' | ||
| Content-Type: | ||
| - application/json | ||
| User-Agent: | ||
| - python-requests/2.32.3 | ||
| X-Traceloop-SDK-Version: | ||
| - 1.0.0 | ||
| method: POST | ||
| uri: https://api-staging.traceloop.com/v2/datasets/test-external-url/rows/cmidceiv6001h01r5odn89gid/cells/video/external-url | ||
| response: | ||
| body: | ||
| string: '{"storage":"external","success":true,"url":"https://www.youtube.com/watch?v=example"}' | ||
| headers: | ||
| CF-RAY: | ||
| - 9a3a2c2beea1997f-TLV | ||
| Connection: | ||
| - keep-alive | ||
| Content-Encoding: | ||
| - gzip | ||
| Content-Type: | ||
| - application/json; charset=utf-8 | ||
| Date: | ||
| - Mon, 24 Nov 2025 16:09:45 GMT | ||
| Permissions-Policy: | ||
| - geolocation=(self), microphone=() | ||
| Server: | ||
| - cloudflare | ||
| Transfer-Encoding: | ||
| - chunked | ||
| cf-cache-status: | ||
| - DYNAMIC | ||
| referrer-policy: | ||
| - strict-origin-when-cross-origin | ||
| strict-transport-security: | ||
| - max-age=7776000; includeSubDomains | ||
| via: | ||
| - kong/3.7.1 | ||
| x-content-type: | ||
| - nosniff | ||
| x-kong-proxy-latency: | ||
| - '0' | ||
| x-kong-request-id: | ||
| - 347c686e553aca5cbdd1ff50c33cc648 | ||
| x-kong-upstream-latency: | ||
| - '14' | ||
| status: | ||
| code: 200 | ||
| message: OK | ||
| version: 1 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.