Skip to content

fix(google-generativeai): defer google-generativeai to allow omission from runtime dependencies #3127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
timkpaine wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(google-generativeai): defer google-generativeai to allow omission from runtime dependencies #3127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0b0afe
fix: defer google-generativeai imports
timkpaine Jul 14, 2025
490213f
Update imports to reflect google submodule change
timkpaine Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions ...ntation-google-generativeai/opentelemetry/instrumentation/google_generativeai/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,8 @@

import logging
import types
from typing import Collection
from typing import Collection, TYPE_CHECKING

from google.genai.types import GenerateContentResponse
from opentelemetry import context as context_api
from opentelemetry._events import get_event_logger
from opentelemetry.instrumentation.google_generativeai.config import Config
Expand Down Expand Up @@ -33,6 +32,10 @@
from opentelemetry.trace import SpanKind, get_tracer
from wrapt import wrap_function_wrapper

if TYPE_CHECKING:
from google.genai.types import GenerateContentResponse


logger = logging.getLogger(__name__)

WRAPPED_METHODS = [
Expand Down Expand Up @@ -61,7 +64,7 @@ def is_async_streaming_response(response):

def _build_from_streaming_response(
span,
response: GenerateContentResponse,
response: "GenerateContentResponse",
llm_model,
event_logger,
):
Expand All @@ -81,7 +84,7 @@ def _build_from_streaming_response(


async def _abuild_from_streaming_response(
span, response: GenerateContentResponse, llm_model, event_logger
span, response: "GenerateContentResponse", llm_model, event_logger
):
complete_response = ""
async for item in response:
Expand Down
9 changes: 9 additions & 0 deletions packages/opentelemetry-instrumentation-google-generativeai/tests/test_generate_content.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import sys

from opentelemetry.sdk._logs import LogData
from opentelemetry.semconv._incubating.attributes import (
event_attributes as EventAttributes,
Expand Down Expand Up @@ -163,3 +165,10 @@ def assert_message_in_logs(log: LogData, event_name: str, expected_content: dict
else:
assert log.log_record.body
assert dict(log.log_record.body) == expected_content


def test_imports():
# Ensure heavy dependencies are not accidentally imported
import opentelemetry.instrumentation.google_generativeai # noqa: F401

assert "google.genai" not in sys.modules