Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incomplete example to fix #591 #2191

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

kguelzau
Copy link

- use optional dependencies, instead of test dependencies
- https://python-poetry.org/docs/pyproject/#extras
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@nirga
Copy link
Member

nirga commented Oct 22, 2024

@kguelzau attaching here the comment from the issue
#591 (comment)

I'm not sure this is the right way to do that - I think this will force the instrumentation to pull an OpenAI dependency, no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants