Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update __init__.py #2189

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

AranavMahalpure
Copy link

The change updates the OpenTelemetry Anthropic instrumentation to capture and record system messages as span attributes, improving observability and consistency in LLM interactions. This allows for better insights and metrics regarding the influence of system prompts on language model behavior.

The change updates the OpenTelemetry Anthropic instrumentation to capture and record system messages as span attributes, improving observability and consistency in LLM interactions. This allows for better insights and metrics regarding the influence of system prompts on language model behavior.
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Oct 21, 2024
@CLAassistant
Copy link

CLAassistant commented Oct 21, 2024

CLA assistant check
All committers have signed the CLA.

@dosubot dosubot bot added the python Pull requests that update Python code label Oct 21, 2024
Copy link
Member

@nirga nirga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AranavMahalpure! A few comments:

  • Can you not delete the original PR description and follow the instructions there? They are there for a reason (see following comments)
  • Can you write a proper title to the PR? These are used in the release notes of the SDK so they need to be descriptive
  • Can you add tests?

@AranavMahalpure
Copy link
Author

Hi Nirga,

Thank you for your feedback! I appreciate your insights and will address each of your comments:

Original PR Description: I apologize for removing the original PR description. I understand the importance of maintaining context and following the instructions provided. I will restore the original description and ensure that all relevant information is included as per the guidelines.
Proper Title for the PR: I appreciate your reminder about the title format. I will revise the title to make it more concise and descriptive, following the suggested format for better clarity in the release notes.
Suggested title: [feat][anthropic]: Enhance OpenTelemetry instrumentation to capture system messages as span attributes

Thank you again for your constructive comments. I will make the necessary updates and keep you posted on the progress!

Best,
Aranav Mahalpure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests that update Python code size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants