Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #2927

Merged
merged 2 commits into from
Mar 20, 2025
Merged

Fix typos #2927

merged 2 commits into from
Mar 20, 2025

Conversation

crutcher
Copy link
Contributor

Pull Request Template

Checklist

  • Confirmed that run-checks all script has been executed.
  • Made sure the book is up to date with changes in this PR.

Changes

Fixed a number of typos, only one in code.

Testing

ran ./run-checks all, but it has lots of unrelated errors

Copy link

codecov bot commented Mar 20, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.14%. Comparing base (26269a6) to head (f808d6a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/burn-candle/src/backend.rs 0.00% 1 Missing ⚠️
crates/burn-ndarray/src/ops/simd/avgpool.rs 0.00% 1 Missing ⚠️
crates/burn-ndarray/src/ops/simd/maxpool.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2927      +/-   ##
==========================================
+ Coverage   82.13%   82.14%   +0.01%     
==========================================
  Files         866      866              
  Lines      120052   120052              
==========================================
+ Hits        98603    98618      +15     
+ Misses      21449    21434      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@laggui laggui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes!

Missed a small one, but I'll approve in advance.

@@ -180,7 +180,7 @@ impl<F: FloatCandleElement, I: IntCandleElement> Backend for Candle<F, I> {
fn name(device: &Self::Device) -> String {
match device {
CandleDevice::Cpu => "candle<cpu>",
CandleDevice::Cuda(..) => "cancle<cuda>",
CandleDevice::Cuda(..) => "candle<cuda>",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤣

@laggui laggui merged commit 536cadb into tracel-ai:main Mar 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants