Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two autotune issues on wasm #2899

Merged
merged 2 commits into from
Mar 12, 2025
Merged

Conversation

ArthurBrussee
Copy link
Contributor

Pull Request Template

Changes

On WASM autotuning is async, and until the results are in, it needs to use a default setting. ATM it just picks the first one, which atm uses atomic floats, and thus results in an error.

For convolution, it needed to simply bubble up the cube count too large error rather than panic'ing.

Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.33%. Comparing base (a1ca434) to head (07e6c4f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2899      +/-   ##
==========================================
- Coverage   82.33%   82.33%   -0.01%     
==========================================
  Files         868      868              
  Lines      118565   118563       -2     
==========================================
- Hits        97617    97615       -2     
  Misses      20948    20948              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@laggui laggui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for keeping us in sync with wasm 😄

@nathanielsimard nathanielsimard merged commit 1727c30 into tracel-ai:main Mar 12, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants