Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update cubecl #2888

Merged
merged 7 commits into from
Mar 12, 2025
Merged

update cubecl #2888

merged 7 commits into from
Mar 12, 2025

Conversation

louisfd
Copy link
Member

@louisfd louisfd commented Mar 10, 2025

No description provided.

@louisfd louisfd requested a review from nathanielsimard March 10, 2025 15:47
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 90.56604% with 5 lines in your changes missing coverage. Please review.

Project coverage is 82.32%. Comparing base (a1ca434) to head (d034bc6).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ubecl/src/kernel/conv/conv2d/gemm/loader/im2col.rs 0.00% 3 Missing ⚠️
...cl/src/kernel/conv/conv2d/gemm/homogeneous/base.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2888      +/-   ##
==========================================
- Coverage   82.33%   82.32%   -0.02%     
==========================================
  Files         868      867       -1     
  Lines      118565   118525      -40     
==========================================
- Hits        97617    97570      -47     
- Misses      20948    20955       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@laggui laggui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just some minor comments.

Btw audit issue was fixed in #2896

@laggui laggui merged commit 5a74fc1 into main Mar 12, 2025
11 checks passed
@laggui laggui deleted the chore/update_cubecl branch March 12, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants