-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ONNX op Random Normal Like #2441
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2441 +/- ##
==========================================
+ Coverage 85.25% 85.29% +0.03%
==========================================
Files 792 793 +1
Lines 104552 104646 +94
==========================================
+ Hits 89140 89260 +120
+ Misses 15412 15386 -26 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your ongoing contribution to enhance ONNX support!
I think overall looks good. However, this PR raises yet another issue with input shapes (discussed here previously: #2304 (comment)). In short, Burn tracks shapes dynamically but ONNX allows for static and dynamic shapes - we should get away from static shapes.
I am approving this PR with a condition that you file a new issue to enhance RandomLike that would figure out shapes dynamically. You can link and update this description to say it only handles static input shapes. And the other issue will refactor it. It will contain two action items: enhance Burn's tensor method with new random_like
method and update this burn-import.
CCing @laggui @nathanielsimard
Pull Request Template
Checklist
run-checks all
script has been executed.Related Issues/PRs
#1714
Changes
This pull request introduces support for the
RandomNormalLike
operation in theburn-import
crate. The most important changes include updating the supported ONNX operations, adding the necessary test files, and modifying the codebase to integrate the new operation.Testing
run-checks all
has passed and it succeeded in generating model withcargo r -- ./onnx-tests/tests/random_normal_like/random_normal_like.onnx ./out