Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Migrate to cubecl IR refactor #2418

Merged
merged 6 commits into from
Oct 30, 2024

Conversation

wingertge
Copy link
Contributor

Pull Request Template

Checklist

  • Confirmed that run-checks all script has been executed.
  • Made sure the book is up to date with changes in this PR.

Related Issues/PRs

Depends on tracel-ai/cubecl#199

Changes

Migrates legacy kernels to the new Variable struct.

Testing

All tests pass on all backends (exempting one CUDA test that was already failing before).

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.28%. Comparing base (d383478) to head (d24048c).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2418      +/-   ##
==========================================
- Coverage   85.30%   85.28%   -0.02%     
==========================================
  Files         792      792              
  Lines      104634   104511     -123     
==========================================
- Hits        89257    89133     -124     
- Misses      15377    15378       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wingertge wingertge marked this pull request as ready for review October 30, 2024 13:45
@nathanielsimard nathanielsimard merged commit 5730f02 into tracel-ai:main Oct 30, 2024
11 checks passed
@wingertge wingertge deleted the feat/cubecl-ir-refactor branch October 30, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants