Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deny.toml to follow the spec changes of cargo-deny #2408

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

tiruka
Copy link
Contributor

@tiruka tiruka commented Oct 23, 2024

Pull Request Template

I am not sure deny.toml with xtask is used now. But I submit a fix PR cause security is important.

Checklist

  • Confirmed that run-checks all script has been executed.
  • Made sure the book is up to date with changes in this PR.

Related Issues/PRs

EmbarkStudios/cargo-deny#611

Changes

I found errors as follows and the command stops before executing.

% cargo xtask dependencies deny                   
    Finished `dev` profile [optimized] target(s) in 0.41s
     Running `target/xtask/debug/xtask dependencies deny`
[2024-09-18T02:51:35Z INFO  tracel_xtask] Execution environment: std
[2024-09-18T02:51:36Z INFO  tracel_xtask::commands::dependencies] Cargo: run deny checks
[2024-09-18T02:51:36Z INFO  tracel_xtask::utils::process] Command line: cargo deny check
error[deprecated]: this key has been removed, see https://github.com/EmbarkStudios/cargo-deny/pull/611 for migration information
   ┌─ /Users/tiruka/Desktop/oss-fork/burn/deny.toml:20:1
   │
20 │ vulnerability = "deny"
   │ ━━━━━━━━━━━━━

error[deprecated]: this key has been removed, see https://github.com/EmbarkStudios/cargo-deny/pull/611 for migration information
   ┌─ /Users/tiruka/Desktop/oss-fork/burn/deny.toml:22:1
   │
22 │ unmaintained = "deny"
   │ ━━━━━━━━━━━━

error[deprecated]: this key has been removed, see https://github.com/EmbarkStudios/cargo-deny/pull/611 for migration information
   ┌─ /Users/tiruka/Desktop/oss-fork/burn/deny.toml:26:1
   │
26 │ notice = "deny"
   │ ━━━━━━

error[deprecated]: this key has been removed, see https://github.com/EmbarkStudios/cargo-deny/pull/611 for migration information
   ┌─ /Users/tiruka/Desktop/oss-fork/burn/deny.toml:74:1
   │
74 │ unlicensed = "deny"
   │ ━━━━━━━━━━

error[deprecated]: this key has been removed, see https://github.com/EmbarkStudios/cargo-deny/pull/611 for migration information
   ┌─ /Users/tiruka/Desktop/oss-fork/burn/deny.toml:76:1
   │
76 │ copyleft = "deny"
   │ ━━━━━━━━

warning[deprecated]: this key has been moved to [graph]
  ┌─ /Users/tiruka/Desktop/oss-fork/burn/deny.toml:9:1
  │
9 │ targets = [
  │ ━━━━━━━

2024-09-18 02:51:36 [ERROR] failed to validate configuration file /Users/tiruka/Desktop/oss-fork/burn/deny.toml
Error: Some dependencies don't meet the requirements!

When seeing EmbarkStudios/cargo-deny#611,
the advisories section has updated its defaults: vulnerabilities, unmaintained, unsound, and notices are now all set to deny, changing from a previous warning status and so on.
I modified the

Testing

cargo xtask dependencies deny command run successfully though there are violations.

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.26%. Comparing base (80c831b) to head (4637c1b).
Report is 19 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2408   +/-   ##
=======================================
  Coverage   85.26%   85.26%           
=======================================
  Files         792      792           
  Lines      104516   104516           
=======================================
+ Hits        89115    89116    +1     
+ Misses      15401    15400    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tiruka
Copy link
Contributor Author

tiruka commented Oct 23, 2024

I noticed CI on macos sometimes fails due to hardware diff. (is there any improvement ?)

@syl20bnr syl20bnr self-requested a review October 24, 2024 02:14
@syl20bnr
Copy link
Member

I noticed CI on macos sometimes fails due to hardware diff. (is there any improvement ?)

I am not aware of any improvement regarding this.

@syl20bnr syl20bnr merged commit 69856a9 into tracel-ai:main Oct 30, 2024
11 checks passed
@syl20bnr
Copy link
Member

Thank you for the PR !

@tiruka tiruka deleted the fix-cargo-deny-toml branch October 30, 2024 13:49
@tiruka
Copy link
Contributor Author

tiruka commented Oct 30, 2024

Thank you for your review and merge 👍

I am not aware of any improvement regarding this.

Ok, I may look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants