Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use core::error::Error for no-std #2346

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Conversation

antimora
Copy link
Collaborator

@antimora antimora commented Oct 8, 2024

Pull Request Template

Checklist

  • Confirmed that run-checks all script has been executed.

Related Issues/PRs

rust-lang/rust#103765

Changes

Removed feature gate for decorating error types with core::error.

Testing

run all checks.

Copy link
Member

@laggui laggui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Though it looks like the feature is not stabilized yet

@antimora
Copy link
Collaborator Author

Awesome! Though it looks like the feature is not stabilized yet

I forgot we maintain two last versions. This works only with the latest stable Rust. So we'll have to wait.

@laggui laggui marked this pull request as draft October 17, 2024 19:23
@antimora antimora marked this pull request as ready for review October 29, 2024 21:48
@antimora
Copy link
Collaborator Author

Reopened since MSRV is 1.81 now per #2388

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.29%. Comparing base (c0e9753) to head (5ac80a5).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2346   +/-   ##
=======================================
  Coverage   85.29%   85.29%           
=======================================
  Files         792      792           
  Lines      104479   104479           
=======================================
  Hits        89118    89118           
  Misses      15361    15361           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@antimora antimora requested a review from laggui October 29, 2024 23:12
@laggui laggui merged commit 5989cf3 into tracel-ai:main Oct 30, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants