-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gradle: Fix executable bit #112
Conversation
This fixes the gradle compose script not being marked as executable for Linux and macOS systems.
PR Summary
|
Kudos, SonarCloud Quality Gate passed! |
This problem probably stretches over all my repos. I work on windows, and the CI file starts with a |
@5HT2 Also fyi, you copied the |
Oh god that's embarrassing. Thank you for pointing it out, I realized earlier that gradle compose was something I had not seen before :p I should have changed the commit message back to just gradle. I've just been porting mods for myself and fixing the chmod bits along the way when people forget to enable it, I didn't pay too much attention when making the commits 😭 |
Happens :D. I just wrote that small "compose" wrapper around the gradle wrapper that spawns data managed at https://github.com/tr7zw/ModComposeTemplate/tree/1.19.4 using the https://github.com/tr7zw/EntityCulling/blob/1.19.4/gradle-compose.yml file. Otherwise I'd go insane managing all the Forge/Fabric dependencies/CI scripts/Gradle files/small utility classes/etc over 10? projects with 6+ version branches each. In the end I'm just one person doing this for fun^^. |
that's very cool !! thank you for explaining what it is c: |
This fixes the gradle compose script not being marked as executable for Linux and macOS systems.