-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minecraft 1.21 #158
Minecraft 1.21 #158
Conversation
PR Summary
|
Will check it later, rn still working on getting 1.21-Neoforge working and added to the modbase. Didn't have enough time last night and work rn. |
The build seems to fail on 1.16.5. You can do a full local build with |
FYI, 1.21-forge and 1.21-neoforge should also now be valid targets, and if the 1.21-fabric code is done right, just work when added to the settings.json. Just try to keep it in the same order as the above versions, so ...
"1.20.6-forge",
"1.20.6-neoforge",
"1.20.6-fabric",
"1.21-forge",
"1.21-neoforge",
"1.21-fabric" If they build they are probably fine, runClient currently doesn't work for forge/neoforge 1.20.6/1.21, so for testing the built jar needs to be thrown into a normal forge/neoforge setup. |
I'm not sure if we should add them here, since this pr is for 1.21 fabric IMO |
There is no reason just to do Fabric, as the code base is the same for all 3, and I only will release with all 3 done^^. Otherwise, I can accept the pr when it works and add the 2 lines myself. |
Done, Forge and NeoForge now added to the valid targets |
Neat, will check it out in a moment. Just did EntityCulling(built worked, will test later), now looking into a glaring issue with FirstPerson and updating it to 1.21. |
Btw also contact me on discord, will give you a contributor role etc. |
Haven't tested compatibility with older Minecraft versions.
The old
render
method in CustomizableModelPart is kept for compat with mods calling this method (like ETF) so they won't need to update to use (unless they inject their code into this).