Skip to content

Fix bug in power limit decimal placing #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 5, 2025
Merged

Fix bug in power limit decimal placing #23

merged 1 commit into from
Jan 5, 2025

Conversation

tr4nt0r
Copy link
Owner

@tr4nt0r tr4nt0r commented Jan 5, 2025

Fixes power limit wrongfully being converted to float (0.0-12.0W) with 1 decimal place. Correct value is integer 0-120W without decimals. Additionally adjusts to step size of 5W like used in the GUI

Fixes power limit wrongfully being converted to float 0.0-12.0W. Correct value is integer 0-120W. Additionally adjust to step size of 5W like used in the GUI
@tr4nt0r tr4nt0r added the 👻 bug Something isn't working label Jan 5, 2025
Copy link

codecov bot commented Jan 5, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (085c9cf) to head (317a657).

Files with missing lines Patch % Lines
pynecil/client.py 0.00% 1 Missing ⚠️
pynecil/types.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main     #23   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          6       6           
  Lines        425     426    +1     
=====================================
- Misses       425     426    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tr4nt0r tr4nt0r changed the title Fix bug in power limit conversion Fix bug in power limit decimal place Jan 5, 2025
@tr4nt0r tr4nt0r changed the title Fix bug in power limit decimal place Fix bug in power limit decimal placing Jan 5, 2025
@tr4nt0r tr4nt0r merged commit e079f2d into main Jan 5, 2025
8 checks passed
@tr4nt0r tr4nt0r deleted the fix_power_limit branch January 5, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👻 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant