-
Notifications
You must be signed in to change notification settings - Fork 87
Executable examples and tutorials #592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
883955c to
f781ddc
Compare
6590673 to
fa1ec70
Compare
|
@nelimee Do you happen to know if there is a time limit on the docs build? For some reason, a code block that produces an output locally is not working in the github-pages build. Edit: It looks like this might be an nbsphinx issue, probably. I just tried a test If we don't let the sphinx build fail for warnings, it works! https://tqec.github.io/tqec/pull/592/user_guide/cnot_test.html Compare this to https://tqec.github.io/tqec/pull/592/gallery/cnot.html#Example-Circuit |
|
I still can't find the source for why the code block in the examples gallery is not executed, whereas the I cannot tell if Lines 45 to 50 in 8f2f79a
Lines 3 to 8 in 8f2f79a
|
Isn't that because the notebook has some cells that are executed? The rule is the following:
|
Ooh. Thanks for this! I thought if at least one cell is unexecuted, then that one gets executed, but not the others that have an output. |
Co-authored-by: Adrien Suau <12374487+nelimee@users.noreply.github.com>
|
I think this PR is ready. I will take a quick look through the diff tomorrow before requesting a review. |
Co-authored-by: Adrien Suau <12374487+nelimee@users.noreply.github.com>
nelimee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is fine for me, just change the cache key to make it valid across OSes and add the input enableCrossOsArchive to true to make that possible, and I will approve :)
Co-authored-by: Adrien Suau <12374487+nelimee@users.noreply.github.com>
|
|
The new cache was saved after the build took approximately 50 mins. Retriggering the docs build to ensure the new cache is used. Edit: The new cache was used by the retriggered build. As expected, it took approximately 8 mins. I think it might be fine to delete the previous cache that used Linux for the key. |
nelimee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, well done, that was a long run, but that is a very convenient feature :)
|
🪓 PR closed, deleted preview at https://tqec.github.io/tqec/pull/592/ |
|
Merging this does not use the cache. The cache exists but it can't be found on main |
That's expected according to cache sharing rules I think. That should not be a problem for the next runs, as branches should be able to use the cache on main. |
|
It is strange to see two different caches of the same name. One is on main and the other one is specific to the PR. Can you update your other PR and check if the https://github.com/tqec/tqec/actions/caches |
Only tomorrow :/ According to https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/caching-dependencies-to-speed-up-workflows#restrictions-for-accessing-a-cache, cache on main can be used by other branches. |
|
Cache hit in #562, everything seems to work correctly :) |
|
It might be necessary to version the cache according to the current detector database version. In any case, we will need to make sure that the detector database is correctly handled. |





To do:
refs.bibjupyter-sphinxfor tutorials