Ruby C extension files support #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Calling Please add the same |
Owner
|
Oh, and while you're making changes, please swap |
Contributor
Author
|
Thanks for the prompt feedback! I've made the changes now. Please let me know if you have any other remarks! |
tpope
added a commit
that referenced
this pull request
Jun 6, 2015
Also lower the precedence of the path addition. References #25.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this PR brings Ruby C extension files support discussed in #24.
I think all the suggestions from there are implemented.
Additionally I've checked the Ruby "logic" (fetching Ruby include directory) on multiple Linux machines and even on Windows (Cygwin). Ruby code has been tweaked a bit to support older ruby versions (1.8.7).
Please let me know if you have any feedback on this!
Thanks