Skip to content
This repository has been archived by the owner on Apr 13, 2021. It is now read-only.

comments with 2.13 #246

Open
tpolecat opened this issue Feb 3, 2019 · 10 comments
Open

comments with 2.13 #246

tpolecat opened this issue Feb 3, 2019 · 10 comments

Comments

@tpolecat
Copy link
Owner

tpolecat commented Feb 3, 2019

In 2.13 comments evidently work differently so something like

```tut
// foo
1 + 1
```

Will report an error and then continue just fine, but it will fail the compile.

See Gitter discussion at ☝️ February 3, 2019 1:14 PM

@larsrh
Copy link
Contributor

larsrh commented Feb 16, 2019

I worked around it (for now) by moving the comments into the function body.

@erikerlandson
Copy link

This is causing typelevel/spire#759 to fail CI at the doc generation step

@tpolecat
Copy link
Owner Author

tpolecat commented Mar 5, 2019

For now I recommend only generating doc for 2.11 or 2.12

@erikerlandson
Copy link

👍

@larsrh
Copy link
Contributor

larsrh commented Mar 5, 2019

I ended up doing this as a workaround: typelevel/cats-mtl@1e89758

@SethTisue
Copy link
Contributor

has anyone looked into whether the root cause might be a regression in Scala itself?

@larsrh
Copy link
Contributor

larsrh commented May 21, 2019

I think migrating everyone to mdoc in time is infeasible. A thorough investigation would be highly appreciated.

@leifwickland
Copy link

Pureconfig is waiting on a fix for this too, which I mention mostly so I'll get notified of updates.
https://github.com/pureconfig/pureconfig/pull/537/files#diff-354f30a63fb0907d4ad57269548329e3R26

@tpolecat
Copy link
Owner Author

tpolecat commented Aug 9, 2019

This is as good a time as any to deprecate tut, so that's what I'm inclined to do. Mdoc is the way forward.

@leifwickland
Copy link

@tpolecat Thanks for the heads up and for your years of work on tut.

Fristi added a commit to vectos/scala-scraper that referenced this issue Aug 20, 2019
mkroli added a commit to mkroli/dns4s that referenced this issue Sep 8, 2019
ruippeixotog pushed a commit to ruippeixotog/scala-scraper that referenced this issue Sep 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants