Additional settings in onelogin_setting.rb #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding setting to agree with changes in ruby-saml 1.3.1 and later. See SAML-Toolkits/ruby-saml#306 and SAML-Toolkits/ruby-saml@6c54131 Previously, settings.security[:want_assertions_signed] was set to true by ruby-saml/metadata.rb when the metadata.yml contained an idp certificate. Now set in rack-saml.yml with want_assertions_signed: true Also passing the setting :authn_requests_signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding setting to agree with changes in ruby-saml 1.3.1 and later. See SAML-Toolkits/ruby-saml#306 and SAML-Toolkits/ruby-saml@6c54131
Previously, settings.security[:want_assertions_signed] was set to true by ruby-saml/metadata.rb when the metadata.yml contained an idp certificate. Now it must be set explicitly. This change allows it to be set in rack-saml.yml with want_assertions_signed: true
Also passing the setting :authn_requests_signed