쓰로틀링 추가, 스피너 초기 지연 설정 #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 19, 2021 02:03
컴포넌트가 마운트된 후 로딩이 1초 이상 지연될 경우 스피너가 생기도록 수정
dididy
approved these changes
Jun 19, 2021
Comment on lines
-92
to
-99
| useIntersectionObserver({ | ||
| target, | ||
| onIntersect: ([{ isIntersecting }]) => { | ||
| if (isIntersecting) { | ||
| setIsDraw(true); | ||
| } | ||
| }, | ||
| }); |
There was a problem hiding this comment.
해당 커스텀 훅은 이제 다른곳에서 사용하지 않는 것일까요?
There was a problem hiding this comment.
인피니티 스크롤은 여전히 Intersection Observer API 을 사용하기 때문에 커스텀 훅이 사용됩니다!
Intersection Observer API는 특정 요소가 뷰포트에 보이는지 여부에 따라 함수를 실행할 수 있는데, 랜딩 페이지 표지는 디바이스마다 길이가 달라서 이 부분을 일관적으로 처리하기가 어려웠습니다. 따라서 스크롤 이벤트리스너 방식을 사용하되 쓰로틀링으로 성능을 개선했습니다.
반대로 인피니티 스크롤 같은 경우 카드 뷰가 어떤 디바이스든 맞춰서 보이기 때문에 Intersection Observer API를 적용하기 쉬워 그대로 유지했습니다.
Comment on lines
-127
to
-130
| <div | ||
| ref={setTarget} | ||
| className="last-item" | ||
| /> |
| useEffect(() => { | ||
| setTimeout(() => { | ||
| if (spinnerRef.current) { | ||
| spinnerRef.current.style.display = 'flex'; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary