-
-
Notifications
You must be signed in to change notification settings - Fork 548
Spring cleaning #788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spring cleaning #788
Changes from all commits
b8e1c29
c7dd288
b9d44e5
7f4aeea
bda2966
c64e636
591532e
50d6230
0e05f36
e2f97fc
a80fe9f
fb13e94
fc9fba2
f179e5f
76b8205
48cae31
ebd5835
f9825d1
dc62bd6
c44c7d4
3b6bd01
7cdf048
3822793
5b63777
a620048
470149a
b8eee01
1eecd5f
f3412d6
6f96ca2
1dffe50
8d8cd81
4d3193a
dffae55
db57931
bc950dd
d4cdf11
5a6743b
cdb6680
acdbd48
82a32bb
7d139e5
4969c57
7327c89
61498c2
bdb0d17
2d1f2a2
5a5b3dc
9662011
e3bba6b
5058cc9
a6c3ff6
d136a4f
98cbcd9
84c5884
753fe55
b5944ca
40d2583
558000c
1f995b3
2683477
e59afae
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,7 +18,7 @@ on Github: | |
| - `2.8 series of releases <https://github.com/tox-dev/tox/projects/6>`_ | ||
|
|
||
| .. | ||
| Everything below here is generated by `towncrier <https://pypi.python.org/pypi/towncrier>`_. | ||
| Everything below here is generated by `towncrier <https://pypi.org/project/towncrier>`_. | ||
| It is generated once as part of the release process rendering fragments from the `changelog` | ||
| folder. If necessary, the generated text can be edited afterwards to e.g. merge rc changes | ||
| into the final release notes. | ||
|
|
@@ -781,7 +781,7 @@ Improved Documentation | |
| location ({envtmpdir}/pseudo-home). If an index url was specified | ||
| a .pydistutils.cfg file will be written with an index_url setting | ||
| so that packages defining ``setup_requires`` dependencies will not | ||
| silently use your HOME-directory settings or https://pypi.python.org/pypi. | ||
| silently use your HOME-directory settings or PyPi. | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. removed a link here?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. broken.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. my point was maybe we should have replaced it with http://pypi.org instead of removing it. |
||
|
|
||
| - fix `#1 <https://github.com/tox-dev/tox/issues/1>`_: empty setup files are properly detected, thanks Anthon van | ||
| der Neuth | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -38,7 +38,6 @@ If you want to use the scripts in `task/` you need a `.pypirc` with a correctly | |
| .. code-block:: ini | ||
|
|
||
| [pypi] | ||
| ;repository=https://pypi.python.org/pypi | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yay |
||
| ;repository=https://upload.pypi.io/legacy/ | ||
| username=<your username> | ||
| password=<your password> | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,3 +6,6 @@ include setup.py | |
| include tox.ini | ||
| graft doc | ||
| graft tests | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
|
||
| global-exclude __pycache__ | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. still unsure why we need these includes?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. They are excludes :) because otherwise it is possible to pollute a release package with these files.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. see my point in #754 (comment) |
||
| global-exclude *.py[cod] | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| filter out unwanted files in package - by @obestwalter |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| extend the plugin documentation and make lot of small fixes and improvements - by @obestwalter |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| introduce a constants module to be used internally and as experimental API - by @obestwalter |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| tidy up tests - remove unused fixtures, update old cinstructs, etc. - by @obestwalter |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| make the already existing implicit API explicit - by @obestwalter |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| improve tox quickstart and corresponding tests - @obestwalter |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,18 @@ | ||
| .. examples for changelog entries adding to your Pull Requests | ||
|
|
||
| file ``544.doc.rst``:: | ||
|
|
||
| explain everything much better - by @passionate_technicalwriter | ||
|
|
||
| file ``544.feature.rst``:: | ||
|
|
||
| ``tox --version`` now shows information about all registered plugins - by @obestwalter. | ||
| ``tox --version`` now shows information about all registered plugins - by @obestwalter | ||
|
|
||
|
|
||
| file ``571.bugfix.rst``:: | ||
|
|
||
| ``skip_install`` overrides ``usedevelop`` (``usedevelop`` is an option to choose the | ||
| installation type if the package is installed and `skip_install` determines if it should be | ||
| installed at all) - by @ferdonline. | ||
| installed at all) - by @ferdonline | ||
|
|
||
| .. see tox/pyproject.toml for all available categories |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -33,9 +33,12 @@ right next to your ``setup.py`` file:: | |
| # content of: tox.ini , put in same dir as setup.py | ||
| [tox] | ||
| envlist = py27,py36 | ||
|
|
||
| [testenv] | ||
| deps=pytest # install pytest in the venvs | ||
| commands=pytest # or 'nosetests' or ... | ||
| deps = pytest # install pytest in the virtualenv where commands will be executed | ||
| commands = | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. a matter of style, but do we need here the line break? shouldn't the comment came right after the = and align alongside that all subsequent lines? mostly to keep it consistent with the deps line, also in Python according to PEP-8 two spaces are recommended before the comment, should the deps line follow this rule, to have the most consistent experience? |
||
| # whatever extra steps before testing might be necessary | ||
| pytest # or any other test runner that you might use | ||
|
|
||
| You can also try generating a ``tox.ini`` file automatically, by running | ||
| ``tox-quickstart`` and then answering a few simple questions. | ||
|
|
@@ -63,13 +66,12 @@ Current features | |
|
|
||
| - test-tool agnostic: runs pytest, nose or unittests in a uniform manner | ||
|
|
||
| * :doc:`(new in 2.0) plugin system <plugins>` to modify tox execution with simple hooks. | ||
| * :doc:`plugin system <plugins>` to modify tox execution with simple hooks. | ||
|
|
||
| * uses pip_ and setuptools_ by default. Support for configuring the installer command | ||
| through :confval:`install_command=ARGV`. | ||
|
|
||
| * **cross-Python compatible**: CPython-2.7, 3.4 and higher, | ||
| Jython and pypy_. | ||
| * **cross-Python compatible**: CPython-2.7, 3.4 and higher, Jython and pypy_. | ||
|
|
||
| * **cross-platform**: Windows and Unix style environments | ||
|
|
||
|
|
@@ -92,10 +94,6 @@ Current features | |
| * supports :ref:`using different / multiple PyPI index servers <multiindex>` | ||
|
|
||
|
|
||
| .. _pypy: http://pypy.org | ||
|
|
||
| .. _`tox.ini`: :doc:configfile | ||
|
|
||
| .. toctree:: | ||
| :hidden: | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,20 +1,24 @@ | ||
|
|
||
| .. _`Cookiecutter`: https://cookiecutter.readthedocs.io | ||
| .. _`pluggy`: https://pluggy.readthedocs.io | ||
| .. _`cookiecutter-tox-plugin`: https://github.com/tox-dev/cookiecutter-tox-plugin | ||
| .. _devpi: http://doc.devpi.net | ||
| .. _Python: http://www.python.org | ||
| .. _virtualenv: https://pypi.python.org/pypi/virtualenv | ||
| .. _virtualenv3: https://pypi.python.org/pypi/virtualenv3 | ||
| .. _virtualenv5: https://pypi.python.org/pypi/virtualenv5 | ||
| .. _`py.test`: http://pytest.org | ||
| .. _virtualenv: https://pypi.org/project/virtualenv | ||
| .. _`pytest`: https://pytest.org | ||
| .. _nosetests: | ||
| .. _`nose`: https://pypi.python.org/pypi/nose | ||
| .. _`nose`: https://pypi.org/project/nose | ||
| .. _`Holger Krekel`: https://twitter.com/hpk42 | ||
| .. _`pytest-xdist`: https://pypi.python.org/pypi/pytest-xdist | ||
| .. _`pytest-xdist`: https://pypi.org/project/pytest-xdist | ||
|
|
||
| .. _`easy_install`: http://peak.telecommunity.com/DevCenter/EasyInstall | ||
| .. _pip: https://pypi.python.org/pypi/pip | ||
| .. _setuptools: https://pypi.python.org/pypi/setuptools | ||
| .. _pip: https://pypi.org/project/pip | ||
| .. _setuptools: https://pypi.org/project/setuptools | ||
| .. _`jenkins`: https://jenkins.io/index.html | ||
| .. _sphinx: https://pypi.python.org/pypi/Sphinx | ||
| .. _discover: https://pypi.python.org/pypi/discover | ||
| .. _unittest2: https://pypi.python.org/pypi/unittest2 | ||
| .. _mock: https://pypi.python.org/pypi/mock/ | ||
| .. _sphinx: https://pypi.org/project/Sphinx | ||
| .. _discover: https://pypi.org/project/discover | ||
| .. _unittest2: https://pypi.org/project/unittest2 | ||
| .. _mock: https://pypi.org/project/mock/ | ||
| .. _pypy: http://pypy.org | ||
|
|
||
| .. _`Python Packaging Guide`: https://packaging.python.org/tutorials/distributing-packages/#packaging-your-project | ||
| .. _`tox.ini`: :doc:configfile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a version of this that ensures that the import entries within one line are ABC ordered? do we want to enforce that as a best practice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a look and there is not (yet), but we're not the only ones who'd like that: asottile/reorder-python-imports#8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could also use isort, it has options for this. It's less good about identifying modules but might be good enough