Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add py39 test environment to docs #1756

Merged
merged 2 commits into from
Dec 21, 2020
Merged

Conversation

Clivern
Copy link

@Clivern Clivern commented Dec 3, 2020

Thanks for contributing a pull request!

If you are contributing for the first time or provide a trivial fix don't worry too
much about the checklist - we will help you get started.

Contribution checklist:

(also see CONTRIBUTING.rst for details)

  • wrote descriptive pull request text
  • added/updated test(s)
  • updated/extended the documentation
  • added relevant issue keyword
    in message body
  • added news fragment in changelog folder
    • fragment name: <issue number>.<type>.rst for example (588.bugfix.rst)
    • <type> is must be one of bugfix, feature, deprecation,breaking, doc, misc
    • if PR has no issue: consider creating one first or change it to the PR number after creating the PR
    • "sign" fragment with "by :user:<your username>"
    • please use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files - by :user:superuser."
    • also see examples
  • added yourself to CONTRIBUTORS (preserving alphabetical order)

@asottile
Copy link
Contributor

asottile commented Dec 3, 2020

instead, I think it would be better to mention the heuristics tox uses to create environments here -- that way this doesn't invite more bitrot / noisy PRs as new versions of python comes out

tox currently understands the following patterns:

  • py: the current interpreter tox is using
  • pypy: whatever available pypy there is
  • jython: whatever available jython there is
  • py#: python of major version #
  • pypy#: pypy of major version #
  • py#%%: cpython version #.%%
  • pypy#%%: pypy version #.%%

@Clivern
Copy link
Author

Clivern commented Dec 3, 2020

I updated to naming pattern @asottile, pls check & feel free to update PR if needed.

Copy link
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaborbernat gaborbernat merged commit 69af6cd into tox-dev:master Dec 21, 2020
ssbarnea pushed a commit to ssbarnea/tox that referenced this pull request Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants