Skip to content

Conversation

@XuehaiPan
Copy link
Contributor

Changes:

  1. Add * to function signature to mark the deprecated argument poll_intervall as keyword only.

  2. Add stacklevel=2 for deprecation warnings, show the file and lineno for the user's code rather than this module (filelock).

    From Fix misspelled keyword argument poll_interval for method acquire #119 (comment):

    I don't know where it's coming from (maybe virtualenv?) but I'm getting a lot of warnings

@XuehaiPan XuehaiPan requested a review from gaborbernat December 4, 2021 08:27
@gaborbernat gaborbernat merged commit 7dc1378 into tox-dev:main Dec 26, 2021
@XuehaiPan XuehaiPan deleted the better-warnings branch December 26, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants