Use uvx instead uv uv run --no-sync to run pre-commit#9
Closed
zeevro wants to merge 3 commits intotox-dev:mainfrom
Closed
Use uvx instead uv uv run --no-sync to run pre-commit#9zeevro wants to merge 3 commits intotox-dev:mainfrom
uvx instead uv uv run --no-sync to run pre-commit#9zeevro wants to merge 3 commits intotox-dev:mainfrom
Conversation
Collaborator
|
Thanks for the PR! This is fixing a bug and adding a feature. Please could you split the feature into another PR? Why is The regression should be fixed in uv and will be in the next release:
Hopefully that'll be fairly soon given their release cadence? This PR essentially changes: uv run --with pre-commit-uv pre-commit ...To: uvx --python '${{ env.pythonLocation }}' --with pre-commit-uv pre-commit ...Which is an alias for: uv tool run --python '${{ env.pythonLocation }}' --with pre-commit-uv pre-commit ...What are the key differences between Is it still worthwhile even after astral-sh/uv#14184 is released? |
Collaborator
Now fixed in https://github.com/astral-sh/uv/releases/tag/0.8.7. |
Member
|
Yeah we no longer need this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solves a regression in
uvthat makes the action fail onuv>0.8.1(currently the latest version is 0.8.6).Also this fixes #6.