Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include grpc error message in tracing #422

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

xiaoyawei
Copy link

Motivation

Currently the tracing middleware only captures the gRPC status code when extracting the error out of a http response. Besides the code, gRPC also requires a human-readable message for error handling, and it'll be useful in this message is extracted from the response as well.

Solution

Per gRPC over HTTP/2 Protocol, a percent-encoded message is included in grpc-message field in the response header / trailer. So this PR also extracts this value and include it in the extracted GrpcFailureClass, such that the downstream usages can use this message for tracing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant