avoid abort_on_panic dependency #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RalfJung
force-pushed
the
abort_on_panic
branch
from
d80ba7c
to
7961ebb
Compare
RalfJung
commented
Aug 31, 2022
RalfJung
force-pushed
the
abort_on_panic
branch
4 times, most recently
from
17cd6b1
to
9d64793
Compare
RalfJung
force-pushed
the
abort_on_panic
branch
from
9d64793
to
57afc1c
Compare
|
I don't know what's happening on riscv here, might be a problem that already exist on master? |
|
@RalfJung The riscv errors are unrelated and I've seen them before. Sadly some of the tests are a bit flaky. Thanks for the patch! |
|
These changes have been released in version 3.0.1. |
RalfJung
added a commit
to RalfJung/miri
that referenced
this pull request
Sep 2, 2022
…ion" This reverts commit 5f3545e. With tov/libffi-rs#58 landed, we no longer depend on abort_on_panic.
bors
added a commit
to rust-lang/miri
that referenced
this pull request
Sep 2, 2022
re-enable FFI support tov/libffi-rs#58 landed so the license should no longer be an issue. :) Fixes #2526
|
Awesome, thanks. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be implemented trivially in a 10-line macro, so it does not seem worth the dependency.
abort_on_panic is licensed under CC0 which is falling out of favor and which might be a problem for having Miri depend on libffi-rs.
(I have implemented this from scratch without looking at the abort_on_panic code.)