Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tosu on linux #306

Merged
merged 2 commits into from
Mar 15, 2025
Merged

Fix tosu on linux #306

merged 2 commits into from
Mar 15, 2025

Conversation

KotRikD
Copy link
Member

@KotRikD KotRikD commented Mar 15, 2025

No description provided.

@KotRikD KotRikD merged commit d36f957 into master Mar 15, 2025
3 checks passed
@KotRikD KotRikD deleted the fix/osu-winello-fix branch March 15, 2025 16:36

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main reason we support installing tosu in the script using the Windows version is exactly for this reason: we don't expect tosu to be on-par with everything we do upstream.

Most of our fixes are just to make osu! (and related) work, all while keeping our implementation of tosu working.
This fix is fine, too, but in the future just point people at using our implementation or using TOSU_OSU_PATH for their custom scripts, it'll be way easier for you.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I understand, that's why it's a joke that I have to crutch for a particular script because most people use it, instead of having a single more or less universal implementation

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And using windows build instead of linux one is good too. But still exist people who want native build of tosu instead of calling through API translator as wine do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants