-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]: @suspensive/react-query-next-experimental #1155
Comments
Can you give me more details of work on this ? I am interested in this work |
There is no @tanstack/react-query-next-experimental@4 You can see this link to check it But in my opinion, There is no reason to support TanStack Query v4 to make it be able to use Next.js app router HTML Streaming. There is so many people using TanStack Query v4 still to support lower version browser yet. So I want to support them to use streaming html with @suspensive/react-query-next-experimental |
@2-NOW See docs to know why we support TanStack Query v4 in our doc I know "this attempt to support TanStack Query v4 + Next.js App router HTML Streaming" could be failure but if we can, It will make big impact |
I have a few thoughts and i'd love to know what you think experimental features are open to change, including the interface. important thing, i think that the layer that provides intermediate compatibility should be stable. |
In my opinion, TanStack don't modify @tanstack/react-query@^4 so that make us to get quite good stability to support @suspensive/react-query-next-experimental as TanStack Query v4 community resources. and @tanstack/react-query-next-experimental is quite stable for me. maybe they will convert its name as @tanstack/react-query-next soon. In open source world, In my opinion, early timing to support something could be good for our getting library users choice too. so I think this timing could be good to support @suspensive/react-query-next-experimental too |
And We support @tanstack/react-query@^5 too by @suspensive/react-query(internally @suspensive/react-query-4, @suspensive/react-query-5 made by @gwansikk). @suspensive/react-query-5 re-export to help migration from "TanStack Query v4 + @suspensive/react-query" to "TanStack Query v5 + @suspensive/react-query" TanStack Query v4 + @suspensive/react-queryimport { useSuspenseQuery } from '@suspensive/react-query' // This re-export @suspensive/react-query-4's useSuspenseQuery TanStack Query v5 + @suspensive/react-queryimport { useSuspenseQuery } from '@suspensive/react-query' // This re-export @tanstack/react-query's useSuspenseQuery Then, In my opinion, @suspensive/react-query-next-experimental could be implemented similar with @suspensive/react-query's way TanStack Query v4 + @suspensive/react-query-next-experimentalimport { ReactQueryStreamedHydration } from '@suspensive/react-query-next-experimental' // This re-export @suspensive/react-query-next-experimental-4's ReactQueryStreamedHydration TanStack Query v5 + @suspensive/react-query-next-experimentalimport { ReactQueryStreamedHydration } from '@suspensive/react-query-next-experimental' // This re-export @tanstack/react-query-next-experimental's ReactQueryStreamedHydration |
I assume you're expecting the experimental feature to become stable soon, if so, |
@gwansikk Could you support @2-NOW later to make @suspensive/react-query-next-experimental? In my opinion, you will be best person to support it. @kangju2000 @bigsaigon333 @SEOKKAMONI I unassigned you guys to narrowen assignee to focus who do this. but if you guys have interest in it. then let me know to assign you guys please |
@2-NOW Thank you very much for your contribution. I will assist you with features that universally support two packages version( |
Show coauthors |
People can be co-author:
|
# Overview #1155 Adds a streaming without prefetching feature that brings the [react-query-next-experimental](https://tanstack.com/query/latest/docs/framework/react/guides/advanced-ssr#experimental-streaming-without-prefetching-in-nextjs) feature available in react-query v5 to v4 - [x] Add a default implementation - HydrationStreamProvider - ReactQueryStreamedHydration - [x] ~~Test working well~~ continue with the follow-up. <!-- A clear and concise description of what this pr is about. --> ## PR Checklist - [x] I did below actions if need 1. I read the [Contributing Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md) 2. I added documents and tests. --------- Co-authored-by: Jonghyeon Ko <[email protected]> Co-authored-by: Jonghyeon Ko <[email protected]>
Package Scope
@suspensive/react-query, @suspensive/react-query-4, etc
Description
Support TanStack Query v4 actively
Possible Solution
No response
etc.
No response
The text was updated successfully, but these errors were encountered: