Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(split): Add split to compat/string #1067

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

shren207
Copy link
Contributor

@shren207 shren207 commented Mar 22, 2025

close #1046

The testcases follow lodash.split.

Test Results

Test List

test

Test Coverage

coverage

Bench Test

bench

🚧 Both lodash split method and es-toolkit split method internally use the native Array#split method, so the performance difference is negligible.

Copy link

vercel bot commented Mar 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-toolkit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 30, 2025 4:44am

@shren207 shren207 changed the title feat(compat): Implement compat/split feat(split): add split to compat Mar 23, 2025
@shren207 shren207 changed the title feat(split): add split to compat feat(split): dd split to compat Mar 23, 2025
@shren207 shren207 changed the title feat(split): dd split to compat feat(split): Add split to compat Mar 23, 2025
@shren207 shren207 changed the title feat(split): Add split to compat feat(split): Add split to compat/string Mar 23, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.32%. Comparing base (fd56626) to head (5c6ff8c).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1067      +/-   ##
==========================================
- Coverage   99.35%   99.32%   -0.03%     
==========================================
  Files         391      392       +1     
  Lines        3430     3432       +2     
  Branches     1022     1023       +1     
==========================================
+ Hits         3408     3409       +1     
- Misses         22       23       +1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add split to compat package
2 participants