-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(over): Add over
to compat/util
#1059
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
over
to compat
over
to compatover
to compat/util
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1059 +/- ##
=======================================
Coverage 99.36% 99.36%
=======================================
Files 393 394 +1
Lines 3443 3447 +4
Branches 1025 1025
=======================================
+ Hits 3421 3425 +4
Misses 22 22 🚀 New features to boost your workflow:
|
|
||
describe('over', () => { | ||
it('should create a function that invokes `iteratees`', () => { | ||
const func = over([Math.max, Math.min]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the lodash test case, the array was not wrapped.
Not just this line, but in other lines as well, the array was not wrapped. Please check everything again. 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the thorough code review! It seems I missed some details in the finer parts.
I’ll make sure to review the upcoming PR you mentioned to better understand the parts I missed.
Once again, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are only minor changes left in the documentation and test cases, so I will merge it first and make the adjustments later!
If you're curious about which parts needed modification, please refer to the PR that will be uploaded later.
Thank you for your contribution!!
I found out that a specific action isn't supported, so there are a lot of changes. You can check them in this PR! 🙏 |
I added
over
function to compat. (close #1050)Test Results
Test List
Test Coverage
Bench Test (2x faster than lodash)