Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compat): add functions to compat layer #1056

Merged
merged 13 commits into from
Mar 30, 2025
Merged

Conversation

kimpuro
Copy link
Contributor

@kimpuro kimpuro commented Mar 16, 2025

I added functions in compat layer.

Resolves: #1036

Most of the code is identical to lodash.
The test code is also the same, with some additional code added for test coverage.
스크린샷 2025-03-16 오후 2 58 19

These are the benchmark results.
스크린샷 2025-03-16 오후 2 55 59

If there is anything missing, please let me know!
Thank you.

Copy link

vercel bot commented Mar 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-toolkit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 30, 2025 7:54am

@kimpuro kimpuro changed the title feat(functions): add functions to compat layer feat(compat): add functions to compat layer Mar 19, 2025
@dayongkr
Copy link
Collaborator

It would be better to use keys from the compat package instead of Object.keys, and minor documentation updates are needed.

Since these are very minor issues, I'll modify them directly after merging.

Thank you for your contribution!!

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.36%. Comparing base (b0b2d08) to head (50db129).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1056   +/-   ##
=======================================
  Coverage   99.36%   99.36%           
=======================================
  Files         392      393    +1     
  Lines        3439     3443    +4     
  Branches     1024     1025    +1     
=======================================
+ Hits         3417     3421    +4     
  Misses         22       22           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dayongkr dayongkr merged commit 1dd2466 into toss:main Mar 30, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add functions to compat package
3 participants