Avoid Duplicated IDs in a page #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After this commit ids are not generate, and the links in toc doesn't work anymore. |
|
No. This PR just resolved the id duplication. Although the ids in each anchor are removed, the ids in each heading keep remaining. If you find any issue I'm missing, creating an |
|
@toshimaru my headers are written with HTML and my markdown processor is Or, if possible, you could check that the header has an ID and then generate one in the anchor if it does not. |
N7K4
pushed a commit
to n13org/jekyll-toc-navtotop
that referenced
this pull request
Feb 29, 2020
* Organize test directory * Avoid duplicated id in a page * Add minitest-reporters * Fix failed tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
According to W3C HTML Validator, it says:
related issue: #73
Resolution
Others