URL-Encoding for anchor link inside toc #113

toshimaru · 2020-05-04T10:34:08Z

closes #95, closes #101

Description

BEFORE

href inside toc:

<li class="toc-entry toc-h1"><a href="#あ">あ</a>

href inside the anchor:

<a class="anchor" href="#%E3%81%82" aria-hidden="true"> ...あ

AFTER

href inside toc:

<li class="toc-entry toc-h1"><a href="#%E3%81%82">あ</a>

href inside the anchor:

<a class="anchor" href="#%E3%81%82" aria-hidden="true"> ...あ

CGI.escape for URL-encoding
Refactoring: Create Helper module
Refactoring: Do not use Nokogiri::HTML(parser.toc), use parser.build_toc instead

Url-Encoding for element id (spaces and UTF-8 support)

5213c6c

toshimaru self-assigned this May 4, 2020

toshimaru added 7 commits May 5, 2020 03:29

Create Helper module and move method to helper

251cc5a

TestOptionError -> TestInvalidOptions

bc6e2fd

Update test_japanese_toc

b1e2efd

Use parser.build_toc instead of Nokogiri::HTML

0556e31

Use CGI.escape instead of ERB url_encode

f043f5b

Use url-encoded string

ebe73ce

Remove Nokogiri::HTML

4280172

toshimaru marked this pull request as ready for review May 5, 2020 15:55

toshimaru added 2 commits May 6, 2020 01:57

attr_accessor -> attr_reader

5dc48df

Add comment for auto URL encoded string

8a4ea7f

toshimaru changed the title ~~Url-Encoding for element id (spaces and UTF-8 support)~~ Url-Encoding for element id May 5, 2020

toshimaru changed the title ~~Url-Encoding for element id~~ URL-Encoding for anchor link inside toc May 5, 2020

Test: parser.inject_anchors_into_html for Japanese

e5b8f6d

toshimaru merged commit af89f4f into master May 5, 2020

toshimaru deleted the url-encode-for-toc-ID branch May 5, 2020 17:52