Implementing Phoenix-side code to crawl documents using OTA engine #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michielbdejong
approved these changes
Sep 19, 2024
package.json
Outdated
| @@ -2,6 +2,7 @@ | |||
| "name": "phoenix", | |||
| "private": true, | |||
| "dependencies": { | |||
| "@opentermsarchive/engine": "^1.1.2", | |||
There was a problem hiding this comment.
why is this npm package becoming a phoenix dependency?
There was a problem hiding this comment.
Hm, it seems to come from a commit from 5 months agp, you should probably run npm remove @opentermsarchive/engine in the repo root and then commit that.
|
Code is working in development but merging this PR to main is still blocked on #1186 since (we think) that would trigger a deploy to production - don't merge this PR until the necessary production environment variables are in place! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR would implement the OTA engine for crawling document text on document creation, update, and for individual crawls made on-demand by the user. This addresses issue #1168
It also includes error-handling and removes references to the old crawler system.