Configuration overhaul: version 2 for the configuration toml file (breaking changes) #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josecelano
force-pushed
the
878-configuration-overhaul-version-2-for-the-configuration-toml-file-breaking-changes
branch
from
60369da
to
8ffcec1
Compare
josecelano
force-pushed
the
878-configuration-overhaul-version-2-for-the-configuration-toml-file-breaking-changes
branch
from
8ffcec1
to
9b9b178
Compare
josecelano
force-pushed
the
878-configuration-overhaul-version-2-for-the-configuration-toml-file-breaking-changes
branch
from
9b9b178
to
ef9461a
Compare
Althought, it has a default value `info` so you can omit it in the TOML config file.
josecelano
force-pushed
the
878-configuration-overhaul-version-2-for-the-configuration-toml-file-breaking-changes
branch
from
fe7e039
to
7b2f757
Compare
josecelano
force-pushed
the
878-configuration-overhaul-version-2-for-the-configuration-toml-file-breaking-changes
branch
from
8b088e3
to
2341c13
Compare
TSL configuration for HTTP trackers and the Tracker API is still optional. However, when it's provided is enabled. The `ssl_enabled` field was removed. You can remove the whole `tsl_config` to disable TSL. If you want to kee a copy in the TOML file you can just comment the lines. ```toml [[http_trackers]] ... [http_trackers.tsl_config] ssl_cert_path = "./storage/tracker/lib/tls/localhost.crt" ssl_key_path = "./storage/tracker/lib/tls/localhost.key" [http_api] ... [http_api.tsl_config] ssl_cert_path = "./storage/tracker/lib/tls/localhost.crt" ssl_key_path = "./storage/tracker/lib/tls/localhost.key" ```
josecelano
force-pushed
the
878-configuration-overhaul-version-2-for-the-configuration-toml-file-breaking-changes
branch
from
2341c13
to
c5cc9fd
Compare
It remvoes this line: ``` 2024-06-17T18:52:49.196708Z INFO torrust_tracker::bootstrap::jobs: TLS not enabled ``` becuase it doesn't specifu which service the TSl is not enabled for. On the other hand, the output already indicates whether the service is runnig on HTTP or HTTPs: ``` 2024-06-18T07:37:58.595692Z INFO HTTP TRACKER: Started on: http://0.0.0.0:7070 ```
This was referenced Jun 18, 2024
By default all services are disabled. If the service section is missing in the TOML config file it means the service is disabled. From: ```toml [[udp_trackers]] enabled = false bind_address = "0.0.0.0:6969" ``` To: ```toml ``` The `http_api` section has been disabled by default becuase there is no way to override it to disable it, if it's enabled by default. You nned to explicitly enabled the API now.
josecelano
force-pushed
the
878-configuration-overhaul-version-2-for-the-configuration-toml-file-breaking-changes
branch
from
9f075b7
to
06ad5da
Compare
|
ACK 06ad5da |
josecelano
added a commit
to josecelano/torrust-index-gui
that referenced
this pull request
Jun 19, 2024
after some breaking changes introduced in: torrust/torrust-tracker#897
josecelano
added a commit
to torrust/torrust-index-gui
that referenced
this pull request
Jun 19, 2024
305602e fix: [#577] update tracker configuration (Jose Celano) Pull request description: After merging this [PR](torrust/torrust-tracker#897), the tracker's TOML configuration will change. For a list of changes, see this [issue](torrust/torrust-tracker#878). ACKs for top commit: josecelano: ACK 305602e Tree-SHA512: 94d666f32aa7cd671fdbd548e8ce226f3d7c83b9246192860417a368ea34a00ec0d3fda13ff7cb807477c4d15e2751238102c969b3a7813cf3377d9cad4d8bbf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configuration overhaul: version 2 for the configuration TOML file (breaking changes).
See the issue for a full description of changes.
Subtasks
log_levelmandatory with defaultinfovalue.loggingandcoresections.databasesubsection incoresection.netsubsection incoresection.announce_policysubsection incoresection.tracker_policysubsection incoresection.tsl_configsubsection forhttp_trackersandhttp_api.enabledfield from services. If the configuration is present, the service is enabled.