Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add middleware to compress responses #326

Closed
josecelano opened this issue May 16, 2023 · 2 comments · Fixed by #386
Closed

Add middleware to compress responses #326

josecelano opened this issue May 16, 2023 · 2 comments · Fixed by #386
Labels
Enhancement / Feature Request Something New

Comments

@josecelano
Copy link
Member

The HTTP tracker and the API do not send a compressed response.

tower_http::compression middleware could be used.

Links
@alexohneander
Copy link
Contributor

@josecelano Do we want to use this as default or do we want to enable/disable this via a config line?

@da2ce7
Copy link
Contributor

da2ce7 commented Aug 26, 2023 •
edited
Loading

Hello @alexohneander HTTP since the big-bang has supported compression, I sugest that we just blanket enable it for everything; it is a cheap and effective optimization.

@josecelano josecelano linked a pull request Aug 26, 2023 that will close this issue
Added tower-http compression as middleware on both HTTP routers #386
Merged
josecelano added a commit that referenced this issue Aug 26, 2023
@josecelano
Merge #386: Added tower-http compression as middleware on both HTTP r…
8b48b0c 
…outers

22bb98a #326: Use only compression features of tower-http (Alex Wellnitz)
76b270b #326: Add tower-http compression as middleware (Alex Wellnitz)

Pull request description:

  Modified:
  I have added tower-http compression as middleware on both HTTP routers(API, Tracker HTTP).

  All tests were run and were okay.

ACKs for top commit:
  josecelano:
    ACK 22bb98a

Tree-SHA512: 0513f81731d8e0f57e3f26039f727dae01a41ecacd01cabd0b77ee5644e680302e59da762b932afda59ba6a4a7b40c31baf580082031e1a893f09128425055f3
@josecelano josecelano mentioned this issue Aug 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement / Feature Request Something New
Projects
Torrust Solution
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added tower-http compression as middleware on both HTTP routers
3 participants
@josecelano @da2ce7 @alexohneander