Fix destroy command: accept working_dir parameter

[Copilot]

Summary

Fixed the critical bug where destroy command didn't accept or use the --working-dir parameter, preventing it from destroying environments created with custom working directories.

Changes Made

• Updated destroy::handle() signature to accept working_dir: &Path parameter
• Updated command dispatcher to pass working_dir to destroy handler
• Added ProcessRunner::run_destroy_command() test helper method
• Created comprehensive E2E tests for destroy with working directories
• Fixed doctest examples to use new function signature
• All linters pass (markdown, yaml, toml, cspell, clippy, rustfmt, shellcheck)
• All 974 unit tests pass
• All 8 E2E tests pass (4 create + 4 destroy)
• All 4 doctests pass

Technical Details

The destroy command was hardcoded to use PathBuf::from("data") as the repository base directory, while the create command properly used the --working-dir parameter. This caused a mismatch where:

• Create saved environments at: {working_dir}/{env_name}/environment.json
• Destroy looked for them at: data/{env_name}/environment.json

The fix passes working_dir from CLI through to the repository factory in the destroy handler, matching the create command's pattern.

Testing

E2E Tests verify:

1. ✅ Destroy with default working directory (backward compatibility)
2. ✅ Destroy with custom working directory
3. ✅ Full lifecycle: create → destroy with custom working directory
4. ✅ Error handling when environment not found

Doctests verify:

1. ✅ destroy::handle() example with working_dir parameter
2. ✅ DestroyError::help() example with working_dir parameter

Note: Environment state files are preserved in "Destroyed" state for idempotency and audit trail purposes, rather than being completely deleted.

Original prompt

---

This section details on the original issue you should resolve

<issue_title>[Subissue 9/10] Fix Destroy Command: Add Working Directory Support</issue_title>
<issue_description># Fix Destroy Command: Accept Working Directory Parameter

Epic Subissue: 9 of 9
Issue: #Y (to be assigned)
Parent Epic: #34 - Create Environment Command
Depends On: Subissue 8 - Fix Destroy Command Created State Handling
Related: Destroy Presentation Layer, Command Dispatcher

Overview

Fix a critical bug in the destroy command where it doesn't accept or use the --working-dir parameter, causing it to fail when environments are created with custom working directories. The destroy command is hardcoded to look for environments in the data/ directory, ignoring the --working-dir CLI argument that the create command properly supports.

This bug prevents users from managing environment lifecycles when working with custom workspace locations, a feature explicitly supported by the --working-dir flag in the CLI.

Dependencies: This issue depends on Subissue 8 (Created State Handling) being completed first, as manual testing requires being able to destroy Created state environments successfully.

Goals

• Fix destroy command to accept working_dir parameter
• Pass working_dir through the command execution chain
• Maintain backward compatibility with default behavior
• Add comprehensive tests for both default and custom working directories

🏗️ Architecture Requirements

DDD Layer: Presentation (CLI interface)
Module Path: src/presentation/commands/destroy.rs + src/presentation/commands/mod.rs
Pattern: CLI Command Pattern

Module Structure Requirements

• Follow DDD layer separation (see docs/codebase-architecture.md)
• Presentation layer handles CLI argument passing to command handlers
• Maintain consistency with create command's working directory handling

Architectural Constraints

• Working directory must flow from CLI through to repository factory
• Error handling follows project conventions (see docs/contributing/error-handling.md)
• Maintain backward compatibility with default working directory (.)

Anti-Patterns to Avoid

• ❌ Hardcoding directory paths in command handlers
• ❌ Breaking changes to existing destroy behavior with default working directory
• ❌ Inconsistency between create and destroy command working directory handling

Specifications

Current Behavior (Incorrect)

The destroy command is hardcoded to look for environments in the data/ directory:

// src/presentation/commands/destroy.rs (line 74)
pub fn handle(environment_name: &str) -> Result<(), DestroyError> {
    // ...
    
    // Create repository for loading environment state
    let repository_factory = RepositoryFactory::new(Duration::from_secs(30));
    let repository = repository_factory.create(std::path::PathBuf::from("data")); // ❌ Hardcoded
    
    // ...
}

The command dispatcher doesn't pass working_dir to the destroy handler:

// src/presentation/commands/mod.rs
pub fn execute(command: Commands, working_dir: &std::path::Path) -> Result<(), CommandError> {
    match command {
        Commands::Create { action } => {
            create::handle_create_command(action, working_dir)?; // ✅ Uses working_dir
            Ok(())
        }
        Commands::Destroy { environment } => {
            destroy::handle(&environment)?; // ❌ Doesn't receive working_dir
            Ok(())
        }
    }
}

Impact: Environments created with custom --working-dir cannot be found by the destroy command:

# Create environment in custom directory
./torrust-tracker-deployer --working-dir /tmp/workspace create environment --env-file config.json

# Destroy fails - looks in ./data/ instead of /tmp/workspace/data/
./torrust-tracker-deployer --working-dir /tmp/workspace destroy test-env
# Error: Environment not found

Expected Behavior

The destroy command should accept and use the working_dir parameter just like the create command:

Step 1: Update destroy::handle() signature to accept working_dir:

// src/presentation/commands/destroy.rs
pub fn handle(environment_name: &str, working_dir: &std::path::Path) -> Result<(), DestroyError> {
    // Create user output with default stdout/stderr channels
    let mut output = UserOutput::new(VerbosityLevel::Normal);

    // Display initial progress (to stderr)
    output.progress(&format!("Destroying environment '{environment_name}'..."));

    // Validate environment name
    let env_name = EnvironmentName::new(environment_name.to_string()).map_err(|source| {
        let error = DestroyError::InvalidEnvironmentName {
            nam...

</details>

- Fixes torrust/torrust-tracker-deployer#51

<!-- START COPILOT CODING AGENT TIPS -->
---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our [2 minute survey](https://gh.io/copilot-coding-agent-survey).

[josecelano]

@copilot the testing workflow failed:

test src/testing/mock_clock.rs - testing::mock_clock::MockClock::set_time (line 122) ... ok

failures:

---- src/presentation/commands/destroy.rs - presentation::commands::destroy::DestroyError::help (line 169) stdout ----
error[E0061]: this function takes 2 arguments but 1 argument was supplied
  --> src/presentation/commands/destroy.rs:174:17
   |
 7 | if let Err(e) = destroy::handle("test-env") {
   |                 ^^^^^^^^^^^^^^^------------ argument #2 of type `&Path` is missing
   |
note: function defined here
  --> /home/runner/work/torrust-tracker-deployer/torrust-tracker-deployer/src/presentation/commands/destroy.rs:56:8
   |
56 | pub fn handle(environment_name: &str, working_dir: &std::path::Path) -> Result<(), DestroyError> {
   |        ^^^^^^
help: provide the argument
   |
 7 | if let Err(e) = destroy::handle("test-env", /* &Path */) {
   |                                           +++++++++++++

error: aborting due to 1 previous error

For more information about this error, try `rustc --explain E0061`.
Couldn't compile the test.

failures:
    src/presentation/commands/destroy.rs - presentation::commands::destroy::DestroyError::help (line 169)

test result: FAILED. 198 passed; 1 failed; 1 ignored; 0 measured; 0 filtered out; finished in 39.26s

error: doctest failed, to rerun pass `-p torrust-tracker-deployer --doc`
Error: Process completed with exit code 101.

[Copilot]

@copilot the testing workflow failed:

...

Fixed in commit 1da2edc. The doctest example in DestroyError::help() was still using the old function signature. Updated to include the required working_dir parameter.

[josecelano]

ACK 1da2edc