Reestablish E2E Tests (reopened) #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #383 +/- ##
========================================
Coverage 42.05% 42.05%
========================================
Files 79 79
Lines 4829 4829
========================================
Hits 2031 2031
Misses 2798 2798 ☔ View full report in Codecov by Sentry. |
… tests The SQLite file path inside the container is not the same as on hte host: In the container: `sqlite:///var/lib/torrust/index/database/sqlite3.db?mode=rwc` It's an absolute path. From the host: `sqlite://./storage/index/lib/database/sqlite3.db?mode=rwc` It's a relative path to where the test are being executed (root project path). TODO: inject as an env var when running the E2E tests isntead of parsing the config file. ``` TORRUST_INDEX_E2E_SHARED=true TORRUST_INDEX_E2E_PATH_CONFIG="./share/default/config/index.container.sqlite3.toml" cargo test ```
…_id field Some E2E tests were failing becuase a category field in a response was renamed. I have reestablished the old name `category_id`.
josecelano
had a problem deploying
to
coverage
GitHub Actions
Failure
josecelano
force-pushed
the
issue-342-reestablish-e2e-tests-reopen
branch
from
30a4afe
to
7a27bba
Compare
until we reestablish the E2E tests.
josecelano
force-pushed
the
issue-342-reestablish-e2e-tests-reopen
branch
from
7a27bba
to
31351fa
Compare
The Tracker configuration was using MySQL instead of SQLite but the database was not created. We can use SQLite for the Tracker even if in this case we are testing with MySQL becuase E2E test are for the Index not the tracker.
Closed
|
ACK 439ca84 |
|
Hi @da2ce7, I've made the minimum changes to reestablish E2E tests. I want to merge this asap so we have E2E tests enabled again. Not all the old features have been re-established. There are some pending things like:
I will create a new epic issue with a subtasks for each of those items. |
josecelano
force-pushed
the
issue-342-reestablish-e2e-tests-reopen
branch
from
439ca84
to
d92443d
Compare
josecelano
had a problem deploying
to
coverage
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The E2E test suite execution was not reestablished correctly here.
Some env vars were renamed (like
TORRUST_INDEX_E2E_SHARED) so we were not running E2E tests (although they seemed to pass, we were only executing the ones that do not require a shared env).This PR only reestablishes the E2E tests. There are a lot of pending refactors that will be done in new PRs like renaming env vars.