-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User authentication should be done in middleware #369
Closed
mario-nt
wants to merge
4
commits into
torrust:develop
from
mario-nt:39-user-authentication-should-be-done-in-middleware
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
9220a52
feat: [39] new extractor for getting the user_id
mario-nt e21aba2
refactor: [#39] user id extractor refactored
mario-nt 796fef4
refactor: [#39] user id extractor code cleanup
mario-nt acb8610
refactor: [#39] userId extractor - upload handler
mario-nt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,2 @@ | ||
pub mod bearer_token; | ||
pub mod user_id; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
use std::sync::Arc; | ||
|
||
use async_trait::async_trait; | ||
use axum::extract::{FromRef, FromRequestParts}; | ||
use axum::http::request::Parts; | ||
use axum::response::{IntoResponse, Response}; | ||
|
||
use super::bearer_token; | ||
use crate::common::AppData; | ||
use crate::errors::ServiceError; | ||
use crate::models::user::UserId; | ||
|
||
pub struct ExtractLoggedInUser(pub UserId); | ||
|
||
#[async_trait] | ||
impl<S> FromRequestParts<S> for ExtractLoggedInUser | ||
where | ||
Arc<AppData>: FromRef<S>, | ||
S: Send + Sync, | ||
{ | ||
type Rejection = Response; | ||
|
||
async fn from_request_parts(parts: &mut Parts, state: &S) -> Result<Self, Self::Rejection> { | ||
let maybe_bearer_token = match bearer_token::Extract::from_request_parts(parts, state).await { | ||
Ok(maybe_bearer_token) => maybe_bearer_token.0, | ||
Err(_) => return Err(ServiceError::Unauthorized.into_response()), | ||
}; | ||
|
||
//Extracts the app state | ||
let app_data = Arc::from_ref(state); | ||
|
||
match app_data.auth.get_user_id_from_bearer_token(&maybe_bearer_token).await { | ||
Ok(user_id) => Ok(ExtractLoggedInUser(user_id)), | ||
Err(error) => Err(error.into_response()), | ||
} | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mario-nt I think this is non-optional Acum extractor that returns an optional value. That's not the same as an optional extractor. See #39 (comment)