Enable pedantic clippy on CI #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @da2ce7, I do not know why we get some extra errors. I'm using exactly the same toolchain but I do not get any error: Runner: rustc +nightly --version --verbose
rustc 1.71.0-nightly (2f6bc5d25 2023-05-09)
binary: rustc
commit-hash: 2f6bc5d259e7ab25ddfdd33de53b892770218918
commit-date: 2023-05-09
host: x86_64-unknown-linux-gnu
release: 1.71.0-nightly
LLVM version: 16.0.2Mine: $ rustc +nightly --version --verbose
rustc 1.71.0-nightly (2f6bc5d25 2023-05-09)
binary: rustc
commit-hash: 2f6bc5d259e7ab25ddfdd33de53b892770218918
commit-date: 2023-05-09
host: x86_64-unknown-linux-gnu
release: 1.71.0-nightly
LLVM version: 16.0.2I've tried a Mine: clippy 0.1.71 (2f6bc5d 2023-05-09) |
|
I'm using the same version, so no idea why we are getting errors on the runner and not on my local machine. |
|
Hi @da2ce7 @WarmBeer, after debugging for a long time, I found out that I can get the same error locally with the following: For some reason, clippy does not show those errors if incremental compilation is enabled. |
The command: ``` cargo clippy --all-targets -- -D clippy::pedantic ``` shows more errors when the CARGO_INCREMENTAL env var is 0. For unknown reason.
Some more clippy erros came up when you use that env var value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable pedantic clippy on CI.