Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/feedback form #112

Merged
merged 17 commits into from
Aug 17, 2023
Merged

fix/feedback form #112

merged 17 commits into from
Aug 17, 2023

Conversation

Amiditin
Copy link
Contributor

@Amiditin Amiditin commented Aug 9, 2023 •
edited
Loading

Задача #108

Изменения:

  • Изменена логика @ui/form модулей:
    • добавлена типизация
    • изменен нейминг переменных
    • переписан FormContent component
  • Добавлена проверка верификации ReCaptcha
  • Зафиксированы версии всех зависимостей

@Amiditin Amiditin added the bug Something isn't working label Aug 9, 2023
@Amiditin Amiditin linked an issue Aug 9, 2023 that may be closed by this pull request
Форма #108
Closed
@Amiditin Amiditin requested a review from TorinAsakura August 9, 2023 20:10
@Amiditin Amiditin mentioned this pull request Aug 9, 2023
Closed
TorinAsakura
TorinAsakura requested changes Aug 9, 2023
View reviewed changes
landing/fragments/landing-feedback/package.json Outdated Show resolved Hide resolved
ui/form/src/data/index.ts Outdated Show resolved Hide resolved
ui/form/src/data/verifyRecaptcha.request.ts Outdated Show resolved Hide resolved
ui/form/src/form-content/form-content.component.tsx Outdated Show resolved Hide resolved
@Amiditin Amiditin requested a review from TorinAsakura August 10, 2023 22:59
@TorinAsakura TorinAsakura requested review from Nelfimov and removed request for TorinAsakura August 12, 2023 00:10
TorinAsakura
TorinAsakura requested changes Aug 12, 2023
View reviewed changes
Copy link
Member

@TorinAsakura TorinAsakura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

у тебя последний коммит с битой подписью

Nelfimov
Nelfimov requested changes Aug 14, 2023
View reviewed changes
ui/form/src/data/useSubmit.ts Outdated Show resolved Hide resolved
ui/form/src/data/useForms.ts Outdated Show resolved Hide resolved
ui/form/src/data/verifyRecaptcha.request.ts Outdated Show resolved Hide resolved
ui/form/package.json Outdated Show resolved Hide resolved
@TorinAsakura TorinAsakura removed their request for review August 16, 2023 21:44
Nelfimov
Nelfimov approved these changes Aug 17, 2023
View reviewed changes
forks/react-locomotive-scroll/package.json Outdated Show resolved Hide resolved
landing/app/package.json Outdated Show resolved Hide resolved
landing/app/package.json Outdated Show resolved Hide resolved
@TorinAsakura TorinAsakura merged commit 26cc23e into master Aug 17, 2023
@TorinAsakura TorinAsakura deleted the fix/feedback-form branch August 17, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nelfimov Nelfimov Nelfimov approved these changes

@TorinAsakura TorinAsakura TorinAsakura approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Форма
3 participants
@Amiditin @TorinAsakura @Nelfimov