Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing formatting like in irc (e.g. bold, italic, underlined) #60

Open
achsenknopf opened this issue Jan 29, 2017 · 2 comments · May be fixed by #75
Open

Missing formatting like in irc (e.g. bold, italic, underlined) #60

achsenknopf opened this issue Jan 29, 2017 · 2 comments · May be fixed by #75

Comments

@achsenknopf
Copy link

Formatting like bold or italic text does not work. With strg+c b/i bold or italic text can be produced in weechat and is visible in e.g. riot but not displayed bold or italic in weechat itself.
@PureTryOut
Copy link

Huh, it shows bold text for me fine, only italic text is displayed unformatted.
Although text formatted bold on Weechat shows italic on Riot, but seeing this also happens when using the IRC script, it doesn't seem related to here.

screenshot_2017-04-10_15-20-01

screenshot_2017-04-10_15-20-32

@her001
Copy link

her001 commented May 17, 2017 •
edited
Loading

In my testing, weechat displays formatting for sent messages but not received messages. It always uses the body of the message. even when a formatted_body is available.

Edit: This is confirmed by looking through the code. Even if I were misinterpreting the code itself, the comments tell me that formatting incoming messages is TODO.

her001 added a commit to her001/weechat-matrix-protocol-script that referenced this issue May 23, 2017
@her001
Add partial support for formatting incoming HTML
01b861d 
Enable the html_formatting var to use this. Currently supports bold,
italics, and underlines with weechat attributes. Code, strikethroughs,
quotes, and breaks/rules are supported with plain text decorating them.

It would be reasonable to add support for colors and lists in the
future. Unfortunately, some things will never be possible with the
limitations of Weechat, but there may be ways to approximate them better.
All unsupported HTML tags are simply stripped from the message.

This mostly fixes torhve#60.
@her001 her001 linked a pull request May 23, 2017 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add partial support for formatting incoming HTML her001/weechat-matrix-protocol-script
3 participants
@her001 @PureTryOut @achsenknopf