Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 11.x Compatibility #54

Merged
merged 9 commits into from
May 16, 2024

Conversation

laravel-shift
Copy link
Contributor

This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 11.x.

Before merging, you need to:

  • Checkout the l11-compatibility branch
  • Review all comments for additional changes
  • Thoroughly test your package

If you do find an issue, please report it by commenting on this PR to help improve future automation.

@laravel-shift
Copy link
Contributor Author

⚠️ The latest version of Laravel has a dependency for phpunit/phpunit of ^10.5. If you would like to also upgrade your tests, you may run the PHPUnit 10 Shift for free.

@laravel-shift
Copy link
Contributor Author

⚠️ Shift detected GitHub Actions which run jobs using a version matrix. Shift attempted to update your configuration for Laravel 11. However, you should review these changes to ensure the desired combination of versions are built for your package.

@laravel-shift
Copy link
Contributor Author

⚗️ Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch.

To do so, temporarily add Shift's fork to the repositories property of your composer.json:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/laravel-shift/torchlight-laravel.git"
        }
    ]
}

Then update your dependency constraint to reference this branch:

{
    "require": {
        "torchlight/torchlight-laravel": "dev-l11-compatibility",
    }
}

Finally, run: composer update

@ph7jack
Copy link

ph7jack commented Mar 28, 2024

Are there any updates here?

@valpuia604
Copy link

Please merge this..

@naykel76
Copy link

What is the situation here? will this be merged?

I have been unsucessfull in using this fork

@miomech
Copy link

miomech commented Apr 16, 2024

@aarondfrancis I'm certain you're very busy but it would be awesome if we could get this PR merged in.
Don't intend to sound rude in the slightest but this package seems like it's been left to the wayside.

If you need an extra hand I'd be more than happy to help out with at least reviewing PR's. This is an awesome package and it would suck for it to be abandoned. Thanks!

@dasundev
Copy link

dasundev commented May 1, 2024

@aarondfrancis We're waiting for this PR merge.

@xuchunyang
Copy link

I tried the pull request locally and found that it works fine for me; I can see the highlights. This is my first time using Torchlight and I only tried x-torchlight-code blade compoent.

@robdekort
Copy link

Hello there. Plus one for this please. I just moved a customer over to the paid version of Torchlight. However development seems a bit stale unfortunately. We would love to update our project to Laravel 11 soon. Would appreciate an update. Thanks! 🙏

@aarondfrancis aarondfrancis merged commit ecdabd3 into torchlight-api:main May 16, 2024
21 of 22 checks passed
@aarondfrancis
Copy link
Contributor

Thanks for your patience!

@robdekort
Copy link

Amazing, thank you.

@miomech
Copy link

miomech commented May 16, 2024

Thank You!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants