Check callable field sources before execution #228
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firstly thanks for this package! It's helped remove a lot of glue code from a project!
I've spotted some GraphQL queries raising
graphql.error.located_error.GraphQLLocatedError: 'str' object is not callable
.I tracked it down to
custom_cls_resolver
where a check is performed to see whether the block's class has an attribute with the same name as the queried value, to support thegrapple.models.GraphQLField(source=<attr-or-method>)
functionality.The block I was querying contained a sub-block bound to
name
which during resolution,custom_cls_resolver
would fetch thename
attribute fromwagtail.core.blocks.base.Block
and attempt to execute it.This PR adds a check to ensure that any attr is callable before attempting to execute it, allowing queries with blocks bound to
name
to resolve using thestreamfield_resolver
.